Commitdba4245

committed

Fix installation test for Python 3.12 and Windows

Starting in Python 3.12, global and virtual Python environments nolonger automatically ship setuptools (per the "ensurepip" item inhttps://docs.python.org/3.12/whatsnew/3.12.html#removed). Projectsthat use setuptools as a build backend are still supported,including with setup.py using techniques such as "pip install .".In Windows, the "bin" subdir of a virtual environment dir is called"Scripts" instead. Unlike in a global environment (where no namesare universal, and "python3" and "pip3" are more common for thePython 3 commands on some popular Unix-like systems), in a virtualenvironment the "python" and "pip" commands are always present and"python3" and "pip3" are not guaranteed to be present.This commit changes test_installation accordingly. The CI workflowsand documentation still need to be updated.

1 parentc8e303f commitdba4245Copy full SHA for dba4245

File tree

1 file changed

-4

lines changed

test
- test_installation.py

1 file changed

-4

lines changed

`‎test/test_installation.py`

Lines changed: 6 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@`
`4`	`4`	`importast`
`5`	`5`	`importos`
`6`	`6`	`importsubprocess`
	`7`	`+fromgit.compatimportis_win`
`7`	`8`	`fromtest.libimportTestBase`
`8`	`9`	`fromtest.lib.helperimportwith_rw_directory`
`9`	`10`
`@@ -12,8 +13,9 @@ class TestInstallation(TestBase):`
`12`	`13`	`defsetUp_venv(self,rw_dir):`
`13`	`14`	`self.venv=rw_dir`
`14`	`15`	`subprocess.run(["virtualenv",self.venv],stdout=subprocess.PIPE)`
`15`		`-self.python=os.path.join(self.venv,"bin/python3")`
`16`		`-self.pip=os.path.join(self.venv,"bin/pip3")`
	`16`	`+bin_name="Scripts"ifis_winelse"bin"`
	`17`	`+self.python=os.path.join(self.venv,bin_name,"python")`
	`18`	`+self.pip=os.path.join(self.venv,bin_name,"pip")`
`17`	`19`	`self.sources=os.path.join(self.venv,"src")`
`18`	`20`	`self.cwd=os.path.dirname(os.path.dirname(__file__))`
`19`	`21`	`os.symlink(self.cwd,self.sources,target_is_directory=True)`
`@@ -32,14 +34,14 @@ def test_installation(self, rw_dir):`
`32`	`34`	`msg=result.stderrorresult.stdoutor"Can't install requirements",`
`33`	`35`	`)`
`34`	`36`	`result=subprocess.run(`
`35`		`- [self.python,"setup.py","install"],`
	`37`	`+ [self.pip,"install","."],`
`36`	`38`	`stdout=subprocess.PIPE,`
`37`	`39`	`cwd=self.sources,`
`38`	`40`	`)`
`39`	`41`	`self.assertEqual(`
`40`	`42`	`0,`
`41`	`43`	`result.returncode,`
`42`		`-msg=result.stderrorresult.stdoutor"Can'tbuild - setup.py failed",`
	`44`	`+msg=result.stderrorresult.stdoutor"Can'tinstall project",`
`43`	`45`	`)`
`44`	`46`	`result=subprocess.run([self.python,"-c","import git"],stdout=subprocess.PIPE,cwd=self.sources)`
`45`	`47`	`self.assertEqual(`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitdba4245

File tree

1 file changed

1 file changed

`‎test/test_installation.py`

0 commit comments