Commitd6a2d28

committed

Mark some cygpath tests xfail

Two of the groups of cygpath tests in test_util.py generate teststhat fail on Cygwin. There is no easy way to still run, but xfail,just the specific tests that fail, because the groups of tests aregenerated with `@ddt` parameterization, but neither the unittestnor pytest xfail mechanisms interact with that. If`@pytest.mark.parametrized` were used, this could be done. Butthat does not work on methods of test classes that derive fromunittest.TestCase, including those in this project that indirectlyderive from it by deriving from TestBase. The TestBase base classcannot be removed without overhauling many tests, due to fixturesit provides such as rorepo.So this marks too many tests as xfail, but in doing so allows testruns to pass while still exercising and showing status on all thetests, allowing result changes to be observed easily.

1 parent715dba4 commitd6a2d28Copy full SHA for d6a2d28

File tree

1 file changed

-0

lines changed

test
- test_util.py

1 file changed

-0

lines changed

`‎test/test_util.py`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,7 @@`
`13`	`13`	`fromdatetimeimportdatetime`
`14`	`14`
`15`	`15`	`importddt`
	`16`	`+importpytest`
`16`	`17`
`17`	`18`	`fromgit.cmdimportdashify`
`18`	`19`	`fromgit.compatimportis_win`
`@@ -84,13 +85,21 @@ def setup(self):`
`84`	`85`	`"array": [42],`
`85`	`86`	`}`
`86`	`87`
	`88`	`+@pytest.mark.xfail(`
	`89`	`+reason="Many return paths prefixed /proc/cygdrive instead.",`
	`90`	`+raises=AssertionError,`
	`91`	`+ )`
`87`	`92`	`@skipUnless(sys.platform=="cygwin","Paths specifically for Cygwin.")`
`88`	`93`	`@ddt.idata(_norm_cygpath_pairs+_unc_cygpath_pairs)`
`89`	`94`	`deftest_cygpath_ok(self,case):`
`90`	`95`	`wpath,cpath=case`
`91`	`96`	`cwpath=cygpath(wpath)`
`92`	`97`	`self.assertEqual(cwpath,cpath,wpath)`
`93`	`98`
	`99`	`+@pytest.mark.xfail(`
	`100`	`+reason=r'2nd example r".\bar" -> "bar" fails, returns "./bar"',`
	`101`	`+raises=AssertionError,`
	`102`	`+ )`
`94`	`103`	`@skipUnless(sys.platform=="cygwin","Paths specifically for Cygwin.")`
`95`	`104`	`@ddt.data(`
`96`	`105`	`(r"./bar","bar"),`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitd6a2d28

File tree

1 file changed

1 file changed

`‎test/test_util.py`

0 commit comments