Commitcd175a5

committed

Remove no-effect@skipIf on test_untracked_files

It looked like test_untracked_files was sometimes skipped, andspecifically that it would be skipped on Cygwin. But the `@skipIf`on it had the condition: HIDE_WINDOWS_KNOWN_ERRORS and Git.is_cygwin()HIDE_WINDOWS_KNOWN_ERRORS can only ever be true if it is set to atruthy value directly (not an intended use as it's a "constant"),or on native Windows systems: no matter how the environmentvariable related to it is set, it's only checked if is_win, whichis set by checking os.name, which is only "nt" on native Windowssystems, not Cygwin.So whenever HIDE_WINDOWS_KNOWN_ERRORS is true Git.is_cygwin() willbe false. Thus this condition is never true and the test was neverbeing skipped anyway: it was running and passing on Cygwin.

1 parentb198bf1 commitcd175a5Copy full SHA for cd175a5

File tree

1 file changed

-12

lines changed

test
- test_repo.py

1 file changed

-12

lines changed

`‎test/test_repo.py`

Lines changed: 2 additions & 12 deletions

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@`
`13`	`13`	`importpickle`
`14`	`14`	`importsys`
`15`	`15`	`importtempfile`
`16`		`-fromunittestimportmock,skipIf,SkipTest,skip`
	`16`	`+fromunittestimportmock,SkipTest,skip`
`17`	`17`
`18`	`18`	`importpytest`
`19`	`19`
`@@ -42,7 +42,7 @@`
`42`	`42`	`)`
`43`	`43`	`fromgit.repo.funimporttouch`
`44`	`44`	`fromtest.libimportTestBase,with_rw_repo,fixture`
`45`		`-fromgit.utilimportHIDE_WINDOWS_KNOWN_ERRORS,cygpath`
	`45`	`+fromgit.utilimportcygpath`
`46`	`46`	`fromtest.libimportwith_rw_directory`
`47`	`47`	`fromgit.utilimportjoin_path_native,rmtree,rmfile,bin_to_hex`
`48`	`48`
`@@ -764,16 +764,6 @@ def test_blame_accepts_rev_opts(self, git):`
`764`	`764`	`self.rorepo.blame("HEAD","README.md",rev_opts=["-M","-C","-C"])`
`765`	`765`	`git.assert_called_once_with(expected_args,*boilerplate_kwargs)`
`766`	`766`
`767`		`-@skipIf(`
`768`		`-HIDE_WINDOWS_KNOWN_ERRORSandGit.is_cygwin(),`
`769`		`-"""FIXME: File "C:\\projects\\gitpython\\git\\cmd.py", line 671, in execute`
`770`		`- raise GitCommandError(command, status, stderr_value, stdout_value)`
`771`		`- GitCommandError: Cmd('git') failed due to: exit code(128)`
`772`		`- cmdline: git add 1__��ava verb��ten 1_test _myfile 1_test_other_file`
`773`		`- 1_��ava-----verb��ten`
`774`		`- stderr: 'fatal: pathspec '"1__çava verböten"' did not match any files'`
`775`		`- """,`
`776`		`- )`
`777`	`767`	`@with_rw_repo("HEAD",bare=False)`
`778`	`768`	`deftest_untracked_files(self,rwrepo):`
`779`	`769`	`forrun,repo_addinenumerate((rwrepo.index.add,rwrepo.git.add)):`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitcd175a5

File tree

1 file changed

1 file changed

`‎test/test_repo.py`

0 commit comments