Commitc569320

committed

Make an old mock.patch.dict on os.environ clearer

This clarifies that the object's contents are patched, rather thanpatching the attribute used to get the object in the first place.It is also in keeping with the style of patching os.environelsewhere in the test suite.

1 parent98877c5 commitc569320Copy full SHA for c569320

File tree

1 file changed

-1

lines changed

test
- test_git.py

1 file changed

-1

lines changed

`‎test/test_git.py`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -245,7 +245,7 @@ def test_insert_after_kwarg_raises(self):`
`245`	`245`
`246`	`246`	`deftest_env_vars_passed_to_git(self):`
`247`	`247`	`editor="non_existent_editor"`
`248`		`-withmock.patch.dict("os.environ", {"GIT_EDITOR":editor}):# @UndefinedVariable`
	`248`	`+withmock.patch.dict(os.environ, {"GIT_EDITOR":editor}):`
`249`	`249`	`self.assertEqual(self.git.var("GIT_EDITOR"),editor)`
`250`	`250`
`251`	`251`	`@with_rw_directory`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitc569320

File tree

1 file changed

1 file changed

`‎test/test_git.py`

0 commit comments