Commitc282315

Sebastian Thiel

committed

Fix regex to support empty email addresses i.e. 'name <>'

1 parent77e47bc commitc282315Copy full SHA for c282315

File tree

-2

lines changed

-2

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -212,6 +212,11 @@ def test_actor(self):`
`212`	`212`	`self.assertIsInstance(Actor.author(cr),Actor)`
`213`	`213`	`# END assure config reader is handled`
`214`	`214`
	`215`	`+deftest_actor_from_string(self):`
	`216`	`+self.assertEqual(Actor._from_string("name"),Actor("name",None))`
	`217`	`+self.assertEqual(Actor._from_string("name <>"),Actor("name",""))`
	`218`	`+self.assertEqual(Actor._from_string("name last another <some-very-long-email@example.com>"),Actor("name last another","some-very-long-email@example.com"))`
	`219`	`+`
`215`	`220`	`@ddt.data(('name',''), ('name','prefix_'))`
`216`	`221`	`deftest_iterable_list(self,case):`
`217`	`222`	`name,prefix=case`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -534,8 +534,8 @@ class Actor(object):`
`534`	`534`	`can be committers and authors or anything with a name and an email as`
`535`	`535`	`mentioned in the git log entries."""`
`536`	`536`	`# PRECOMPILED REGEX`
`537`		`-name_only_regex=re.compile(r'<(.+)>')`
`538`		`-name_email_regex=re.compile(r'(.*) <(.+?)>')`
	`537`	`+name_only_regex=re.compile(r'<(.*)>')`
	`538`	`+name_email_regex=re.compile(r'(.) <(.?)>')`
`539`	`539`
`540`	`540`	`# ENVIRONMENT VARIABLES`
`541`	`541`	`# read when creating new commits`

Comments

(0)