Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork939
Commitc16e4f3
committed
Restore longer extra time for Windows, and add for macOS
This undoes the testing breakage of test_blocking_lock_file forWindows, and gives macOS the same amount of extra time as Windows.I had expected that macOS, even though it needs more time thanUbuntu, might not need as much extra time as Windows. That turnedout not to be the case, in the limited testing done so far on CI.Windows, while still slower than Ubuntu and still too slow toreliably pass the test_blocking_lock_file test, was usually fasterthan macOS and passed more often.These relative timings may turn out not to be a trend and only toapply to the current GHA runners. That's probably okay since theadjustment for macOS wasn't present before and is being added toallow newly introduced macOS CI test jobs to pass.That is all in regard to the very specific issue of the extra timerequired for the test_blocking_lock_file test after the lock, whichmakes an assertion about that not taking too long. Regarding theoverall time of entire test jobs, macOS 13 seems to have usuallybeen a little faster than macOS 12, so it is retained. Unlike"macos-latest", which currently is macOS 12, "macos-13" will neverrefer to a later version of the operating system, so the versiongiven in the workflow should be revisited later, at or after thetime "macos-latest" becomes a synonym of "macos-13".1 parentf6f335f commitc16e4f3
1 file changed
+1
-1
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
397 | 397 | | |
398 | 398 | | |
399 | 399 | | |
400 | | - | |
| 400 | + | |
401 | 401 | | |
402 | 402 | | |
403 | 403 | | |
| |||
0 commit comments
Comments
(0)