Commitbdff7ec

committed

fix(blame): Support Python 3.7 in the test suite

Apparently the public attributes of a `MagicMock` changed between 3.7 and 3.8,which was causing the unit test for `rev_opts` to fail.The unit test has been improved to use more stable APIs so that it can pass inall versions of Python supported by GitPython.

1 parentc0225b3 commitbdff7ecCopy full SHA for bdff7ec

File tree

1 file changed

-2

lines changed

test
- test_repo.py

1 file changed

-2

lines changed

`‎test/test_repo.py`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -557,8 +557,8 @@ def test_blame_complex_revision(self, git):`
`557`	`557`	`deftest_blame_accepts_rev_opts(self,git):`
`558`	`558`	`res=self.rorepo.blame("HEAD","README.md",rev_opts=["-M","-C","-C"])`
`559`	`559`	`expected_args= ['blame','HEAD','-M','-C','-C','--','README.md']`
`560`		`-foridx,arginenumerate(expected_args):`
`561`		`-self.assertEqual(git.call_args.args[idx],arg)`
	`560`	`+boilerplate_kwargs= {"p" :True,"stdout_as_string":False}`
	`561`	`+git.assert_called_once_with(expected_args,*boilerplate_kwargs)`
`562`	`562`
`563`	`563`	`@skipIf(`
`564`	`564`	`HIDE_WINDOWS_KNOWN_ERRORSandGit.is_cygwin(),`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitbdff7ec

File tree

1 file changed

1 file changed

`‎test/test_repo.py`

0 commit comments