Commitbd86c87

cesarizu

authored and

Byron

committed

FixAttributeError when searching a remote by name

Running code like `'origin' in git.Repo('path/to/existing/repository').remotes`raises an AttributeError instead of returning a boolean. This commit fixes thatbehaviour by catching the error when doing an identity match on `IterableList`.

1 parente93ffe1 commitbd86c87Copy full SHA for bd86c87

File tree

2 files changed

-3

lines changed

AUTHORS
git
- util.py

2 files changed

-3

lines changed

`‎AUTHORS`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -32,5 +32,6 @@ Contributors are:`
`32`	`32`	`-A. Jesse Jiryu Davis <jesse _at_ emptysquare.net>`
`33`	`33`	`-Steven Whitman <ninloot _at_ gmail.com>`
`34`	`34`	`-Stefan Stancu <stefan.stancu _at_ gmail.com>`
	`35`	`+-César Izurieta <cesar _at_ caih.org>`
`35`	`36`
`36`	`37`	`Portions derived from other open source works and are clearly marked.`

`‎git/util.py`

Lines changed: 6 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -864,9 +864,12 @@ def __init__(self, id_attr, prefix=''):`
`864`	`864`
`865`	`865`	`def__contains__(self,attr):`
`866`	`866`	`# first try identity match for performance`
`867`		`-rval=list.__contains__(self,attr)`
`868`		`-ifrval:`
`869`		`-returnrval`
	`867`	`+try:`
	`868`	`+rval=list.__contains__(self,attr)`
	`869`	`+ifrval:`
	`870`	`+returnrval`
	`871`	`+except (AttributeError,TypeError):`
	`872`	`+pass`
`870`	`873`	`# END handle match`
`871`	`874`
`872`	`875`	`# otherwise make a full name search`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitbd86c87

File tree

2 files changed

2 files changed

`‎AUTHORS`

`‎git/util.py`

0 commit comments