Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitba56752

Browse files
committed
Update test_git_submodules_and_add_sm_with_new_commit skip reason
This is working on Cygwin, so that old reason no longer applies.(The test was not being skipped on Cygwin, and was passing.)It is not working on native Windows, due to a PermissionError fromattempting to move a file that is still open (which Windows doesn'tallow). That may have been the original native Windows skip reason,but the old AppVeyor CI link for it is broken or not public. Thismakes the reason clear, though maybe I should add more details.
1 parentc1798f5 commitba56752

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

‎test/test_submodule.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -750,13 +750,12 @@ def test_list_only_valid_submodules(self, rwdir):
750750

751751
@skipIf(
752752
HIDE_WINDOWS_KNOWN_ERRORS,
753-
"""FIXME on cygwin: File "C:\\projects\\gitpython\\git\\cmd.py", line 671, in execute
754-
raise GitCommandError(command, status, stderr_value, stdout_value)
755-
GitCommandError: Cmd('git') failed due to: exit code(128)
756-
cmdline: git add 1__Xava verbXXten 1_test _myfile 1_test_other_file 1_XXava-----verbXXten
757-
stderr: 'fatal: pathspec '"1__çava verböten"' did not match any files'
758-
FIXME on appveyor: see https://ci.appveyor.com/project/Byron/gitpython/build/1.0.185
759-
""",
753+
"""
754+
E PermissionError:
755+
[WinError 32] The process cannot access the file because it is being used by another process:
756+
'C:\\Users\\ek\\AppData\\Local\\Temp\\test_git_submodules_and_add_sm_with_new_commitu6d08von\\parent\\module'
757+
-> 'C:\\Users\\ek\\AppData\\Local\\Temp\\test_git_submodules_and_add_sm_with_new_commitu6d08von\\parent\\module_moved'
758+
"""# noqa: E501,
760759
)
761760
@with_rw_directory
762761
@_patch_git_config("protocol.file.allow","always")

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp