Commitadd46d9

committed

Use "is" to compare __class__

Since the value of __class__ is a type, comparing it to anothertype object should use "is" rather than "==".Some of these, involving type(), were fixed inbf7af69, but flake8did not catch the .__class__ variation addressed here.

1 parent59d208c commitadd46d9Copy full SHA for add46d9

File tree

1 file changed

-2

lines changed

git/refs
- symbolic.py

1 file changed

-2

lines changed

`‎git/refs/symbolic.py‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -769,7 +769,7 @@ def iter_items(`
`769`	`769`
`770`	`770`	`List is lexicographically sorted`
`771`	`771`	`The returned objects represent actual subclasses, such as Head or TagReference"""`
`772`		`-return (rforrincls._iter_items(repo,common_path)ifr.__class__==SymbolicReferenceornotr.is_detached)`
	`772`	`+return (rforrincls._iter_items(repo,common_path)ifr.__class__isSymbolicReferenceornotr.is_detached)`
`773`	`773`
`774`	`774`	`@classmethod`
`775`	`775`	`deffrom_path(cls:Type[T_References],repo:"Repo",path:PathLike)->T_References:`
`@@ -797,7 +797,7 @@ def from_path(cls: Type[T_References], repo: "Repo", path: PathLike) -> T_Refere`
`797`	`797`	`try:`
`798`	`798`	`instance:T_References`
`799`	`799`	`instance=ref_type(repo,path)`
`800`		`-ifinstance.__class__==SymbolicReferenceandinstance.is_detached:`
	`800`	`+ifinstance.__class__isSymbolicReferenceandinstance.is_detached:`
`801`	`801`	`raiseValueError("SymbolicRef was detached, we drop it")`
`802`	`802`	`else:`
`803`	`803`	`returninstance`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitadd46d9

File tree

1 file changed

1 file changed

`‎git/refs/symbolic.py‎`

0 commit comments