Commitad570de

committed

Avoid unsafe assumptions about tempdir content in tests

test_new_should_raise_on_invalid_repo_location had previously usedtempfile.gettempdir() directly to get a path assumed not to be avalid repository, assuming more than necessary about the directoryin which temporary files and directories are created. A newlycreated temporary directory is now used for that check, instead.test_new_should_raise_on_non_existent_path had assumed norepos/foobar existed relative to the current directory. Typicallythere would be no such directory, but is unnecessary for the testto rely on this. A newly created temporary directory known to beempty is now used in place of the "repos" component, for that test.

1 parentd7bf231 commitad570deCopy full SHA for ad570de

File tree

1 file changed

-2

lines changed

test
- test_repo.py

1 file changed

-2

lines changed

`‎test/test_repo.py`

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -71,15 +71,19 @@ def tearDown(self):`
`71`	`71`	`forlfpinglob.glob(_tc_lock_fpaths):`
`72`	`72`	`ifosp.isfile(lfp):`
`73`	`73`	`raiseAssertionError("Previous TC left hanging git-lock file: {}".format(lfp))`
	`74`	`+`
`74`	`75`	`importgc`
`75`	`76`
`76`	`77`	`gc.collect()`
`77`	`78`
`78`	`79`	`deftest_new_should_raise_on_invalid_repo_location(self):`
`79`		`-self.assertRaises(InvalidGitRepositoryError,Repo,tempfile.gettempdir())`
	`80`	`+withtempfile.TemporaryDirectory()astdir:`
	`81`	`+self.assertRaises(InvalidGitRepositoryError,Repo,tdir)`
`80`	`82`
`81`	`83`	`deftest_new_should_raise_on_non_existent_path(self):`
`82`		`-self.assertRaises(NoSuchPathError,Repo,"repos/foobar")`
	`84`	`+withtempfile.TemporaryDirectory()astdir:`
	`85`	`+nonexistent=osp.join(tdir,"foobar")`
	`86`	`+self.assertRaises(NoSuchPathError,Repo,nonexistent)`
`83`	`87`
`84`	`88`	`@with_rw_repo("0.3.2.1")`
`85`	`89`	`deftest_repo_creation_from_different_paths(self,rw_repo):`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitad570de

File tree

1 file changed

1 file changed

`‎test/test_repo.py`

0 commit comments