Commitaba0494

committed

Renamed refresh to setup and removed alias function & added unittest

Renamed to simplify and avoid issue with nose tests trying to use`setup` as a setup for testing. Unittest implements basic test forrefreshing with a bad git path versus a good git path.

1 parentfeed81e commitaba0494Copy full SHA for aba0494

File tree

2 files changed

+12

-6

lines changed

git
- __init__.py
- test
  - test_git.py

2 files changed

+12

-6

lines changed

`‎git/init.py`

Lines changed: 3 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -58,19 +58,16 @@ def _init_externals():`
`58`	`58`	`__all__= [nameforname,objinlocals().items()`
`59`	`59`	`ifnot (name.startswith('_')orinspect.ismodule(obj))]`
`60`	`60`
	`61`	`+`
`61`	`62`	`#{ Initialize git executable path`
`62`		`-defsetup(path=None):`
	`63`	`+defrefresh(path=None):`
`63`	`64`	`"""Convenience method for setting the git executable path."""`
`64`	`65`	`ifnotGit.refresh(path=path):`
`65`	`66`	`return`
`66`	`67`	`ifnotFetchInfo.refresh():`
`67`	`68`	`return`
`68`		`-`
`69`		`-defrefresh(path=None):`
`70`		`-"""Convenience method for refreshing the git executable path."""`
`71`		`-setup(path=path)`
`72`	`69`	`#} END initialize git executable path`
`73`	`70`
`74`	`71`	`#################`
`75`		`-setup()`
	`72`	`+refresh()`
`76`	`73`	`#################`

`‎git/test/test_git.py`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,7 @@`
`10`	`10`
`11`	`11`	`fromgitimport (`
`12`	`12`	`Git,`
	`13`	`+refresh,`
`13`	`14`	`GitCommandError,`
`14`	`15`	`GitCommandNotFound,`
`15`	`16`	`Repo,`
`@@ -156,6 +157,14 @@ def test_cmd_override(self):`
`156`	`157`	`type(self.git).GIT_PYTHON_GIT_EXECUTABLE=prev_cmd`
`157`	`158`	`# END undo adjustment`
`158`	`159`
	`160`	`+deftest_refresh(self):`
	`161`	`+# test a bad git path refresh`
	`162`	`+self.assertRaises(GitCommandNotFound,refresh,"yada")`
	`163`	`+`
	`164`	`+# test a good path refresh`
	`165`	`+path=os.popen("which git").read().strip()`
	`166`	`+refresh(path)`
	`167`	`+`
`159`	`168`	`deftest_options_are_passed_to_git(self):`
`160`	`169`	`# This work because any command after git --version is ignored`
`161`	`170`	`git_version=self.git(version=True).NoOp()`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitaba0494

File tree

2 files changed

2 files changed

`‎git/init.py`

`‎git/test/test_git.py`

0 commit comments

Movatterモバイル変換

Uh oh!

File tree

2 files changed

2 files changed

‎git/__init__.py

‎git/test/test_git.py

0 commit comments

`‎git/init.py`

`‎git/test/test_git.py`