Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit9ed904c

Browse files
committed
Adjust mypy options to work well with mypy 1.9.0
mypy 1.9.0 was very recently released. This makes two changes,in light of that, while avoiding breaking earlier versions:- Change the Python version mypy assumes from 3.7 to 3.8 as configiured in pyproject.toml, because starting in 1.9.0 mypy no longer supports type checking for Python 3.7. It makes sense to keep having a low version checked on local runs of mypy (when not further overridden with `--python-version`). Since the CI mypy steps currently are written not to fail their jobs if they fail (and they do fail, as there remain some mypy errors that are neither fixed nor suppressed), mypy status from CI is not obvious, and it may be that the main way mypy is actually used when developing GitPython is locally. But keeping it down to 3.7 prints a warning and falls back to the version of Python that is used to run mypy, starting in mypy 1.9.0.- Have each CI job that runs mypy do so for the Python version that job exists to test. (This is already the case for the *platform* that job exists to test, because the platform mypy should check for is not overridden in pyproject.toml.) This is done by passing the test matrix Python version with `--python-version`, which takes priority over the pyproject.toml option (which itself takes priority over the default version selection, which in this case would be the same as what we are turning it back into on CI). This is worthwhile even separately from the changes in mypy 1.9.0. But one of its effects is to make it so the mypy step in the Python 3.7 test jobs still checks Python 3.7 (so the results for 3.7, which GitPython has not yet dropped support for) can still be examined. This works becuase the latest version of mypy that can *run* on 3.7, which pip selects automatically, *does* support type-checking for 3.7.
1 parent87b314e commit9ed904c

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

‎.github/workflows/pythonpackage.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ jobs:
8888

8989
-name:Check types with mypy
9090
run:|
91-
mypy -p git
91+
mypy --python-version=${{ matrix.python-version }} -p git
9292
# With new versions of mypy new issues might arise. This is a problem if there is nobody able to fix them,
9393
# so we have to ignore errors until that changes.
9494
continue-on-error:true

‎pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ testpaths = "test" # Space separated list of paths from root e.g test tests doc
2020
# filterwarnings ignore::WarningType # ignores those warnings
2121

2222
[tool.mypy]
23-
python_version ="3.7"
23+
python_version ="3.8"
2424
disallow_untyped_defs =true
2525
no_implicit_optional =true
2626
warn_redundant_casts =true

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp