Commit98b78d2

committed

Rungc.collect() twice intest_rename on Python 3.12

Recently, the conditional `gc.collect()` step for Python >= 3.12 in`TestSubmodule.test_rename` is often insufficient. This has mainlybeen seen in #2248. For example:https://github.com/gitpython-developers/GitPython/actions/runs/22864869684/job/66331124651?pr=2106#step:12:620In principle, there can be situations with finalizers where a cycleis only collectable due to finalization that happened due to aprevious collection. Therefore, there is occasionally a benefit tocollecting twice. This does that, in the hope that it will help.

1 parentc0a3d5f commit98b78d2Copy full SHA for 98b78d2

File tree

1 file changed

-0

lines changed

test
- test_submodule.py

1 file changed

-0

lines changed

`‎test/test_submodule.py‎`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1011,6 +1011,7 @@ def test_rename(self, rwdir):`
`1011`	`1011`	`# garbage collector detailed in https://github.com/python/cpython/issues/97922.)`
`1012`	`1012`	`ifsys.platform=="win32"andsys.version_info>= (3,12):`
`1013`	`1013`	`gc.collect()`
	`1014`	`+gc.collect()# Some finalizer scenarios need two collections, at least in theory.`
`1014`	`1015`
`1015`	`1016`	`new_path="renamed/myname"`
`1016`	`1017`	`assertsm.move(new_path).name==new_path`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit98b78d2

File tree

1 file changed

1 file changed

`‎test/test_submodule.py‎`

0 commit comments