Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork938
Commit9305567
committed
Add missing pip in $PATH on Cygwin CI
This makes a pip -> pip3 symlink in /usr/bin in a new step prior tothe first step that runs the pip command. Using "pip3", "pip3.9",or a command like "python -m pip" would work, but this allows theCygwin workflow to continue using the same installation commands asthe main testing workflow.Adding this fixes two problems:1. When the pip version installed by the python39-pip package is current, so that upgrading pip doesn't install any new commmand, no "pip" command is created in /usr/local. This has happened not to be the case for a long time, which is why the Cygwin workflow was able to pass. (That the recent failures started at the merge of#1783 turns out to be a coincidence: rerunning jobs on prior commits has the failure, as does experimentally reverting it.)2. Even when the pip version installed by python39-pip is behind the latest available version, pip is still used before being upgraded to check if setuptools is installed, to decide whether to upgrade it. This is to keep similar steps in the two testing workflows similar, since the Cygwin workflow only uses Python 3.9, which always has setuptools. Because pip was never in $PATH in that step, the Cygwin workflow wrongly refrained from trying to upgrade setuptools.When the "Update PyPA packages" step does find a newer version ofpip to upgrade to, it installs it in /usr/local/bin, which we havein $PATH before /usr/bin, so the upgraded version, when present,will still be preferred in subsequent commands, as before.Running "pip" on Cygwin when it may not be in $PATH -- and, for onestep, never is -- was a bug introduced ine8956e5 (#1709). Beforethat, "pip" still was not always available, but it was not used.This change fixes the bug by making sure "pip" is always available.1 parentf5e1b10 commit9305567
1 file changed
+5
-0
lines changedLines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
58 | 63 | | |
59 | 64 | | |
60 | 65 | | |
| |||
0 commit comments
Comments
(0)