Commit8f5f65d

committed

Ask git where its daemon is and use that

This changes the test helpers on Windows to use "git --exec-path"(with whatever "git" GitPython is using) to find the directory thatcontains "git-daemon.exe", instead of finding it in a PATH search.

1 parent91f63cd commit8f5f65dCopy full SHA for 8f5f65d

File tree

2 files changed

-4

lines changed

README.md
test/lib
- helper.py

2 files changed

-4

lines changed

`‎README.md`

Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -118,9 +118,6 @@ _Important_: Right after cloning this repository, please be sure to have`
`118`	`118`	executed`git fetch --tags` followed by the`./init-tests-after-clone.sh`
`119`	`119`	`script in the repository root. Otherwise you will encounter test failures.`
`120`	`120`
`121`		-On_Windows_, make sure you have`git-daemon` in your PATH. For MINGW-git, the`git-daemon.exe`
`122`		-exists in`Git\mingw64\libexec\git-core\`.
`123`		`-`
`124`	`121`	`####Install test dependencies`
`125`	`122`
`126`	`123`	`Ensure testing libraries are installed. This is taken care of already if you installed with:`

`‎test/lib/helper.py`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -182,7 +182,7 @@ def git_daemon_launched(base_path, ip, port):`
`182`	`182`	`# and then CANNOT DIE!`
`183`	`183`	`# So, invoke it as a single command.`
`184`	`184`	`daemon_cmd= [`
`185`		`-"git-daemon",`
	`185`	`+osp.join(Git()._call_process("--exec-path"),"git-daemon"),`
`186`	`186`	`"--enable=receive-pack",`
`187`	`187`	`"--listen=%s"%ip,`
`188`	`188`	`"--port=%s"%port,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit8f5f65d

File tree

2 files changed

2 files changed

`‎README.md`

`‎test/lib/helper.py`

0 commit comments