Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit8ea3133

Browse files
committed
Have init script clone submodules unconditionally
Since7110bf8 (in#1693), "git submodule update --init --recursive"was not run on CI, on the mistaken grounds that the CI testworkflows would already have taken care of cloning all submodules(ever since4eef3ec when the "submodules: recursive" option wasadded to the actions/checkout step).This changes the init-tests-after-clone.sh script to again run thatcommand unconditionally, including on CI. The assumption that itwasn't needed on CI was based on the specific content ofGitPython's own GitHub Actions workflows. But this disregarded thatthe test suite is run on CI for *other* projects: specifically, fordownstream projects that package GitPython (#1713).This also brings back the comment fromfc96980 that says more abouthow the tests rely on submodules being present (specifically, thatthey need a submodule with a submodule). However, that is notspecifically related to the bug being fixed.
1 parentbb48c87 commit8ea3133

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

‎init-tests-after-clone.sh

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,8 @@ git reset --hard HEAD~1
4747
# Point the master branch where we started, so we test the correct code.
4848
git reset --hard __testing_point__
4949

50-
# The tests need submodules. (On CI, they would already have been checked out.)
51-
if! ci;then
52-
git submodule update --init --recursive
53-
fi
50+
# The tests need submodules, including a submodule with a submodule.
51+
git submodule update --init --recursive
5452

5553
# The tests need some version tags. Try to get them even in forks. This fetches
5654
# other objects too. So, locally, we always do it, for a consistent experience.

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp