Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork938
Commit8e8b87a
committed
Fix RootModule.update
It was on the `previous_commit` parameter, and ineffective. It maybe that the original intent of the suppression was to suppress onlyincompatible override type errors due to the addition of thatparameter, but there are other paramters that also mismatch byhaving a different name or by being absent even though present inthe overridden base-class method. Furthermore, even corespondingparameters mismatch in position due to the insertion of the`previous_commit` parameter, so even if there is some way to do amore fine-grained suppression than applying `ignore[override]` tothe entire method signature, that would be insufficient here.This fixes one mypy error. It does so by causing it to be suppressedeffectively, not by fixing the underlying issue, which may not befixable since it would entail a breaking change to fix. However,this does not introduce any new suppressions, just fixes an existingsuppression so it is effective (and probably so it operates asintended, though maybe it is slightly stronger than intended asdiscussed above).ignore[override] suppression1 parent94344b4 commit8e8b87a
1 file changed
+2
-2
lines changedLines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
78 | | - | |
| 78 | + | |
79 | 79 | | |
80 | | - | |
| 80 | + | |
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
| |||
0 commit comments
Comments
(0)