Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit8d97906

Browse files
committed
Don't support building documentation on Python 3.8
This discontinues supporting building documentation on Python 3.8.It does not affect installing or running GitPython on Python 3.8(except when the `doc` extra is used, but this is only used forbuilding documentation). The reason is that it is no longerpossible to use the same version of Sphinx on Python 3.8 as on themost recent supported versions of Python, because Python 3.14 nolonger has `ast.Str` (using `str.Constant` for string literalsinstead), which causes the oldest version of `sphinx` that runs onPython 3.14 to be `sphinx` 7.2.0, while the newest version that isinstallable on Python 3.8 is `sphinx` 7.1.2.The immediately preceding commit changes the requirements for the`doc` extra to specify a newer `sphinx` version for Python 3.9 andlater. This can't be done on Python 3.8. Because there can besubtle differences in documentation generated with different`sphinx` versions, and because Python 3.8 has been end-of-life forsome time, it is not really worth carrying conditional dependenciesfor the `sphinx` version in `doc/requirements.txt`.Note that, while it is probably not a very good idea to useGitPython (or anything) on Python 3.8 since it is end-of-life, thischange does not stop supporting installing GitPython on that or anyother version it has been supporting. Installing and usingGitPython remains supported all the way back to Python 3.7 at thistime. This only affects the `doc` extra and its requirements.This change is analogous to the change made in#1956, whichfollowed up on the change in#1964 in the same way this changefollows up on the change in the immediately preceding commit.
1 parentd1ca2af commit8d97906

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

‎.github/workflows/pythonpackage.yml‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,11 @@ jobs:
3030
-os-type:ubuntu
3131
python-version:"3.7"
3232
os-ver:"22.04"
33+
-build-docs:true# We ensure documentation builds, except on very old interpreters.
34+
-python-version:"3.7"
35+
build-docs:false
36+
-python-version:"3.8"
37+
build-docs:false
3338
-experimental:false
3439

3540
fail-fast:false
@@ -110,7 +115,7 @@ jobs:
110115
continue-on-error:false
111116

112117
-name:Documentation
113-
if:matrix.python-version != '3.7'
118+
if:matrix.build-docs
114119
run:|
115120
pip install '.[doc]'
116121
make -C doc html

‎doc/requirements.txt‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
sphinx>=7.4.7,<8 ;python_version>="3.9"
2-
sphinx>=7.1.2,<7.2 ;python_version<"3.9"
1+
sphinx>=7.4.7,<8
32
sphinx_rtd_theme
43
sphinx-autodoc-typehints

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2026 Movatter.jp