Commit89ade7b

committed

Fix order of operators before executing the git command

Since Python 3.3, the hash value of an object is seeded randomly, making itchange between each call. As a consequence, the `dict` type relying on the hashvalue for the order of the items upon iterating on it, and the parameterspassed to `git` being passed as `kwargs` to the `execute()` method, the orderof parameters will change randomly between calls.For example, when you call `git.remote.pull()` in a code, two consecutives runwill generate:1. git pull --progress -v origin master2. git pull -v --progress origin masterWithin the `transform_kwargs()` method, I'm promoting `kwargs` into an`collections.OrderedDict` being built with `kwargs` sorted on the keys.Then it will ensure that each subsequent calls will execute theparameters in the same order.

1 parentfb577c8 commit89ade7bCopy full SHA for 89ade7b

File tree

1 file changed

-0

lines changed

git
- cmd.py

1 file changed

-0

lines changed

`‎git/cmd.py`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,8 @@`
`13`	`13`	`importerrno`
`14`	`14`	`importmmap`
`15`	`15`
	`16`	`+fromcollectionsimportOrderedDict`
	`17`	`+`
`16`	`18`	`fromcontextlibimportcontextmanager`
`17`	`19`	`importsignal`
`18`	`20`	`fromsubprocessimport (`
`@@ -783,6 +785,7 @@ def transform_kwarg(self, name, value, split_single_char_options):`
`783`	`785`	`deftransform_kwargs(self,split_single_char_options=True,**kwargs):`
`784`	`786`	`"""Transforms Python style kwargs into git command line options."""`
`785`	`787`	`args=list()`
	`788`	`+kwargs=OrderedDict(sorted(kwargs.items(),key=lambdax:x[0]))`
`786`	`789`	`fork,vinkwargs.items():`
`787`	`790`	`ifisinstance(v, (list,tuple)):`
`788`	`791`	`forvalueinv:`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit89ade7b

File tree

1 file changed

1 file changed

`‎git/cmd.py`

0 commit comments