Commit8828ced

committed

Fixed critical issue that would cause a string to be passed to methods that expect a stream

1 parenta5a75ab commit8828cedCopy full SHA for 8828ced

File tree

-4

lines changed

-4

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,7 @@ def __init__(self, filepath=None):`
`130`	`130`
`131`	`131`	`def_read_from_file(self):`
`132`	`132`	`try:`
`133`		`-fmap=file_contents_ro_filepath(self._path,stream=False,allow_mmap=True)`
	`133`	`+fmap=file_contents_ro_filepath(self._path,stream=True,allow_mmap=True)`
`134`	`134`	`exceptOSError:`
`135`	`135`	`# it is possible and allowed that the file doesn't exist !`
`136`	`136`	`return`

Lines changed: 1 addition & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -34,9 +34,7 @@ def test_base(self):`
`34`	`34`	`tdir=tempfile.mktemp(suffix="test_reflogs")`
`35`	`35`	`os.mkdir(tdir)`
`36`	`36`
`37`		`-# verify we have a ref - with the creation of a new ref, the reflog`
`38`		`-# will be created as well`
`39`		`-rlp_master_ro=RefLog.path(self.rorepo.heads.master)`
	`37`	`+rlp_master_ro=RefLog.path(self.rorepo.head)`
`40`	`38`	`assertos.path.isfile(rlp_master_ro)`
`41`	`39`
`42`	`40`	`# simple read`

Comments

(0)