Commit8704d1b

committed

Change test_git_submodules_and_add_sm_with_new_commit Windows skip to xfail

And improve details.The xfail is only for native Windows, not Cygwin (same as the oldskip was, and still via checking HIDE_WINDOWS_KNOWN_ERRORS).This change is analogous to the change inc1798f5, but fortest_git_submodules_and_add_sm_with_new_commit rather thantest_root_module.

1 parentba56752 commit8704d1bCopy full SHA for 8704d1b

File tree

1 file changed

-8

lines changed

test
- test_submodule.py

1 file changed

-8

lines changed

`‎test/test_submodule.py`

Lines changed: 7 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`importtempfile`
`8`	`8`	`frompathlibimportPath`
`9`	`9`	`importsys`
`10`		`-fromunittestimportmock,skipIf,skipUnless`
	`10`	`+fromunittestimportmock,skipUnless`
`11`	`11`
`12`	`12`	`importpytest`
`13`	`13`
`@@ -748,14 +748,13 @@ def test_list_only_valid_submodules(self, rwdir):`
`748`	`748`	`repo=git.Repo(repo_path)`
`749`	`749`	`assertlen(repo.submodules)==0`
`750`	`750`
`751`		`-@skipIf(`
	`751`	`+@pytest.mark.xfail(`
`752`	`752`	`HIDE_WINDOWS_KNOWN_ERRORS,`
`753`		`-"""`
`754`		`- E PermissionError:`
`755`		`- [WinError 32] The process cannot access the file because it is being used by another process:`
`756`		`- 'C:\\Users\\ek\\AppData\\Local\\Temp\\test_git_submodules_and_add_sm_with_new_commitu6d08von\\parent\\module'`
`757`		`- -> 'C:\\Users\\ek\\AppData\\Local\\Temp\\test_git_submodules_and_add_sm_with_new_commitu6d08von\\parent\\module_moved'`
`758`		`- """# noqa: E501,`
	`753`	`+reason=(`
	`754`	`+'"The process cannot access the file because it is being used by another process"'`
	`755`	`++" on first call to sm.move"`
	`756`	`+ ),`
	`757`	`+raises=PermissionError,`
`759`	`758`	`)`
`760`	`759`	`@with_rw_directory`
`761`	`760`	`@_patch_git_config("protocol.file.allow","always")`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit8704d1b

File tree

1 file changed

1 file changed

`‎test/test_submodule.py`

0 commit comments