Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork940
Commit8543457
committed
Use :const: for constants that had the :attr: role
Note that this intentionally does *not* include some all-caps classattributes that are not really constants:- Git.GIT_PYTHON_GIT_EXECUTABLE is set by refresh functions, including on subsequent calls, which is an important and documented part of what those functions do. (Also, it is set automatically from an enviroment variable, which is not constant across runs; that it could not even in principle be replaced by a specific literal value is a further reason it is not a constant.)- The Git.USE_SHELL attribute is a more ambiguous case. It is given a literal value (False) which it preferably remains. But setting it has been documented as something users can do (in the changelog, and later in regard to setting it being a deprecated operation).The first of these is decisively not a constant even under a loosedefinition, while the second is less clear. I've kept both with the:attr: role.1 parentca95c42 commit8543457
2 files changed
+9
-9
lines changedLines changed: 1 addition & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1177 | 1177 |
| |
1178 | 1178 |
| |
1179 | 1179 |
| |
1180 |
| - | |
| 1180 | + | |
1181 | 1181 |
| |
1182 | 1182 |
| |
1183 | 1183 |
| |
|
Lines changed: 8 additions & 8 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
713 | 713 |
| |
714 | 714 |
| |
715 | 715 |
| |
716 |
| - | |
717 |
| - | |
718 |
| - | |
719 |
| - | |
720 |
| - | |
| 716 | + | |
| 717 | + | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
721 | 721 |
| |
722 |
| - | |
723 |
| - | |
| 722 | + | |
| 723 | + | |
724 | 724 |
| |
725 | 725 |
| |
726 | 726 |
| |
| |||
730 | 730 |
| |
731 | 731 |
| |
732 | 732 |
| |
733 |
| - | |
| 733 | + | |
734 | 734 |
| |
735 | 735 |
| |
736 | 736 |
| |
|
0 commit comments
Comments
(0)