Commit78d63d9

committed

Let close_fds be True on all platforms

Since Python 3.7, subprocess.Popen supports close_fds=True on allplatforms, including Windows, and it is the default, includingwhen arguments for standard streams have non-None values passed.3.7 is the lowest version of Python that GitPython supports. Sothis omits the close_fds=True argument from the calls where it waspresent. This has the same effect (in 3.7 and higher) as passingclose_fds=True.When the the close_fd argument was added to the Popen call ingit.cmd.Git.execute in1ee2afb, Python 2 was still supported. InPython 2, close_fds defaulted to False. This appears to be thereason it had been passed explicitly. It was conditioned on beingon a Unix-like system because having it True on Windows wouldprevent stdin, stdout, or stderr redirection.

1 parent96acc22 commit78d63d9Copy full SHA for 78d63d9

File tree

2 files changed

-2

lines changed

git
- cmd.py
- index
  - fun.py

2 files changed

-2

lines changed

`‎git/cmd.py`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1001,7 +1001,6 @@ def execute(`
`1001`	`1001`	`stderr=PIPE,`
`1002`	`1002`	`stdout=stdout_sink,`
`1003`	`1003`	`shell=shell,`
`1004`		`-close_fds=(os.name=="posix"),# Unsupported on Windows.`
`1005`	`1004`	`universal_newlines=universal_newlines,`
`1006`	`1005`	`creationflags=PROC_CREATIONFLAGS,`
`1007`	`1006`	`**subprocess_kwargs,`

`‎git/index/fun.py`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,6 @@ def run_commit_hook(name: str, index: "IndexFile", *args: str) -> None:`
`102`	`102`	`stdout=subprocess.PIPE,`
`103`	`103`	`stderr=subprocess.PIPE,`
`104`	`104`	`cwd=index.repo.working_dir,`
`105`		`-close_fds=(os.name=="posix"),`
`106`	`105`	`creationflags=PROC_CREATIONFLAGS,`
`107`	`106`	`)`
`108`	`107`	`exceptExceptionasex:`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit78d63d9

File tree

2 files changed

2 files changed

`‎git/cmd.py`

`‎git/index/fun.py`

0 commit comments