Commit715dba4

committed

Run cygpath tests on Cygwin, not native Windows

They were not running on Cygwin, because git.util.is_win is Falseon Cygwin. They were running on native Windows, with a number ofthem always failing; these failures had sometimes been obscured bythe --maxfail=10 that had formerly been used (from pyproject.toml).Many of them (not all the same ones) fail on Cygwin, and it mightbe valuable for cygpath to work on other platforms, especiallynative Windows. But I think it still makes sense to limit the teststo Cygwin at this time, because all the uses of cygpath in theproject are in code that only runs after a check that the platformis Cygwin. Part of that check, as it is implemented, explicitlyexcludes native Windows (is_win must be false).

1 parent0eb38bc commit715dba4Copy full SHA for 715dba4

File tree

1 file changed

-5

lines changed

test
- test_util.py

1 file changed

-5

lines changed

`‎test/test_util.py`

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`importsys`
`10`	`10`	`importtempfile`
`11`	`11`	`importtime`
`12`		`-fromunittestimportmock,skipIf`
	`12`	`+fromunittestimportmock,skipUnless`
`13`	`13`	`fromdatetimeimportdatetime`
`14`	`14`
`15`	`15`	`importddt`
`@@ -84,14 +84,14 @@ def setup(self):`
`84`	`84`	`"array": [42],`
`85`	`85`	`}`
`86`	`86`
`87`		`-@skipIf(notis_win,"Paths specifically forWindows.")`
	`87`	`+@skipUnless(sys.platform=="cygwin","Paths specifically forCygwin.")`
`88`	`88`	`@ddt.idata(_norm_cygpath_pairs+_unc_cygpath_pairs)`
`89`	`89`	`deftest_cygpath_ok(self,case):`
`90`	`90`	`wpath,cpath=case`
`91`	`91`	`cwpath=cygpath(wpath)`
`92`	`92`	`self.assertEqual(cwpath,cpath,wpath)`
`93`	`93`
`94`		`-@skipIf(notis_win,"Paths specifically forWindows.")`
	`94`	`+@skipUnless(sys.platform=="cygwin","Paths specifically forCygwin.")`
`95`	`95`	`@ddt.data(`
`96`	`96`	`(r"./bar","bar"),`
`97`	`97`	`(r".\bar","bar"),`
`@@ -104,7 +104,7 @@ def test_cygpath_norm_ok(self, case):`
`104`	`104`	`cwpath=cygpath(wpath)`
`105`	`105`	`self.assertEqual(cwpath,cpathorwpath,wpath)`
`106`	`106`
`107`		`-@skipIf(notis_win,"Paths specifically forWindows.")`
	`107`	`+@skipUnless(sys.platform=="cygwin","Paths specifically forCygwin.")`
`108`	`108`	`@ddt.data(`
`109`	`109`	`r"C:",`
`110`	`110`	`r"C:Relative",`
`@@ -117,7 +117,7 @@ def test_cygpath_invalids(self, wpath):`
`117`	`117`	`cwpath=cygpath(wpath)`
`118`	`118`	`self.assertEqual(cwpath,wpath.replace("\\","/"),wpath)`
`119`	`119`
`120`		`-@skipIf(notis_win,"Paths specifically forWindows.")`
	`120`	`+@skipUnless(sys.platform=="cygwin","Paths specifically forCygwin.")`
`121`	`121`	`@ddt.idata(_norm_cygpath_pairs)`
`122`	`122`	`deftest_decygpath(self,case):`
`123`	`123`	`wpath,cpath=case`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit715dba4

File tree

1 file changed

1 file changed

`‎test/test_util.py`

0 commit comments