Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork938
Commit7057b9b
committed
In handle_process_output don't forward finalizer result
The git.cmd.handle_process_output function is non-public(git.cmd.__all__ only lists Git) but used throughout GitPython andreferenced in the git.util.RemoteProgress.new_message_handlerdocstring. Its finalizer argument is annotated to accept anoptional callable that always returns None. It is always used thisway in GitPython and RemoteProcess.new_message_handler is annotatedaccordingly. However, the handle_process_output docstring andimplementation had documented the return value as the result of thefinalizer, and the implementation had forwarded that result ifpassed.This modifies the docstring and implementation to disregard anyresult, in accordance with the everywhere-annotated assumption thatthe finalizer is conceptually void and the absence of any code inGitPython that uses the result of calling handle_process_output.None is now implicitly returned, simplifying the implementation andbringing it and the docstring in line with annotationd and usage.This would be a breaking change if done on a public function, butbecause handle_process_output is nonpublic (and documentation forit is omitted by Sphinx, so users probably don't wrongly think itis public), I believe this is safe and non-breaking.1 parent86d0177 commit7057b9b
1 file changed
+1
-4
lines changedLines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
111 | 111 | | |
112 | 112 | | |
113 | 113 | | |
114 | | - | |
115 | 114 | | |
116 | 115 | | |
117 | 116 | | |
| |||
205 | 204 | | |
206 | 205 | | |
207 | 206 | | |
208 | | - | |
209 | | - | |
210 | | - | |
| 207 | + | |
211 | 208 | | |
212 | 209 | | |
213 | 210 | | |
| |||
0 commit comments
Comments
(0)