Commit679d2e8

committed

Fix exception type in require_remote_ref_path docstring

The require_remote_ref_path decorator has always used ValueError(ever since its introduction ina92ab80) but was documented asusing TypeError.ValueError is the correct exception to raise here, since this isnot any kind of type error or related condition. So the bug wasn'tin the function's behavior, but instead in the way that behaviorwas documented. (The bug was fairly minor, since the function isnot listed in __all__.)

1 parent254c82a commit679d2e8Copy full SHA for 679d2e8

File tree

1 file changed

-1

lines changed

git/refs
- reference.py

1 file changed

-1

lines changed

`‎git/refs/reference.py`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@`
`25`	`25`
`26`	`26`
`27`	`27`	`defrequire_remote_ref_path(func:Callable[...,_T])->Callable[...,_T]:`
`28`		-"""A decorator raising :class:`TypeError` if we are not a valid remote, based on the
	`28`	+"""A decorator raising :class:`ValueError` if we are not a valid remote, based on the
`29`	`29`	`path."""`
`30`	`30`
`31`	`31`	`defwrapper(self:T_References,*args:Any)->_T:`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit679d2e8

File tree

1 file changed

1 file changed

`‎git/refs/reference.py`

0 commit comments