Commit63104d6

committed

Avoid taking a lock for reading (#1338)

This isn't needed as git will replace this file atomicially,hence we always see a fully written file when reading.Only when writing we need to obtain a lock.

1 parent2141eae commit63104d6Copy full SHA for 63104d6

File tree

2 files changed

-13

lines changed

git
- ext
  - gitdb
- index
  - base.py

2 files changed

-13

lines changed

`‎git/ext/gitdb‎`

Submodulegitdb updated17 files

`‎git/index/base.py‎`

Lines changed: 2 additions & 12 deletions

Original file line number	Diff line number	Diff line change
`@@ -129,28 +129,18 @@ def _set_cache_(self, attr: str) -> None:`
`129`	`129`	`ifattr=="entries":`
`130`	`130`	`# read the current index`
`131`	`131`	`# try memory map for speed`
`132`		`-lfd=LockedFD(self._file_path)`
`133`	`132`	`ok=False`
`134`	`133`	`try:`
`135`		`-fd=lfd.open(write=False,stream=False)`
`136`		`-ok=True`
	`134`	`+fd=os.open(self._file_path,os.O_RDONLY)`
`137`	`135`	`exceptOSError:`
`138`	`136`	`# in new repositories, there may be no index, which means we are empty`
`139`	`137`	`self.entries:Dict[Tuple[PathLike,StageType],IndexEntry]= {}`
`140`	`138`	`returnNone`
`141`		`-finally:`
`142`		`-ifnotok:`
`143`		`-lfd.rollback()`
`144`	`139`	`# END exception handling`
`145`	`140`
`146`	`141`	`stream=file_contents_ro(fd,stream=True,allow_mmap=True)`
`147`	`142`
`148`		`-try:`
`149`		`-self._deserialize(stream)`
`150`		`-finally:`
`151`		`-lfd.rollback()`
`152`		`-# The handles will be closed on destruction`
`153`		`-# END read from default index on demand`
	`143`	`+self._deserialize(stream)`
`154`	`144`	`else:`
`155`	`145`	`super(IndexFile,self)._set_cache_(attr)`
`156`	`146`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit63104d6

File tree

2 files changed

2 files changed

`‎git/ext/gitdb‎`

`‎git/index/base.py‎`

0 commit comments