Commit608147e

committed

Better explain conditional cleanup in test_base_object

This expands the comment added in41fac85 (#1770) to make moreclear that this particular cleanup is deliberately done only whenthe operation was successful (and why).

1 parent018ebaf commit608147eCopy full SHA for 608147e

File tree

1 file changed

-1

lines changed

test
- test_base.py

1 file changed

-1

lines changed

`‎test/test_base.py`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,10 @@ def test_base_object(self):`
`72`	`72`	`self.assertEqual(item,item.stream_data(tmpfile))`
`73`	`73`	`tmpfile.seek(0)`
`74`	`74`	`self.assertEqual(tmpfile.read(),data)`
`75`		`-os.remove(tmpfile.name)# Do it this way so we can inspect the file on failure.`
	`75`	`+`
	`76`	`+# Remove the file this way, instead of with a context manager or "finally",`
	`77`	`+# so it is only removed on success, and we can inspect the file on failure.`
	`78`	`+os.remove(tmpfile.name)`
`76`	`79`	`# END for each object type to create`
`77`	`80`
`78`	`81`	`# Each has a unique sha.`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit608147e

File tree

1 file changed

1 file changed

`‎test/test_base.py`

0 commit comments