Commit5b27339

authored and

Sebastian Thiel

committed

Fix Git.transform_kwarg

Kwargs were not transformed correctly if a value was set to 0 due towrong if condition.Signed-off-by: František Nečas <fifinecas@seznam.cz>

1 parent859ad04 commit5b27339Copy full SHA for 5b27339

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -893,7 +893,7 @@ def transform_kwarg(self, name, value, split_single_char_options):`
`893`	`893`	`else:`
`894`	`894`	`ifvalueisTrue:`
`895`	`895`	`return ["--%s"%dashify(name)]`
`896`		`-elifvaluenotin (False,None):`
	`896`	`+elifvalueisnotFalseandvalueisnotNone:`
`897`	`897`	`return ["--%s=%s"% (dashify(name),value)]`
`898`	`898`	`return []`
`899`	`899`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -86,6 +86,7 @@ def test_it_transforms_kwargs_into_git_command_arguments(self):`
`86`	`86`
`87`	`87`	`assert_equal(["--max-count"],self.git.transform_kwargs(**{'max_count':True}))`
`88`	`88`	`assert_equal(["--max-count=5"],self.git.transform_kwargs(**{'max_count':5}))`
	`89`	`+assert_equal(["--max-count=0"],self.git.transform_kwargs(**{'max_count':0}))`
`89`	`90`	`assert_equal([],self.git.transform_kwargs(**{'max_count':None}))`
`90`	`91`
`91`	`92`	`# Multiple args are supported by using lists/tuples`

Comments

(0)