Commit592ec84

committed

Fix rollback bug in SymbolicReference.set_reference

This fixes the initialization of the "ok" flag by setting it toFalse before the operation that might fail is attempted.(This is a fix for the *specific* problem reported in#1669 abouthow the pattern SymbolicReference.set_reference attempts to usewith LockedFD is not correctly implemented.)

1 parenta5a6464 commit592ec84Copy full SHA for 592ec84

File tree

1 file changed

-1

lines changed

git/refs
- symbolic.py

1 file changed

-1

lines changed

`‎git/refs/symbolic.py`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -370,7 +370,7 @@ def set_reference(`
`370`	`370`
`371`	`371`	`lfd=LockedFD(fpath)`
`372`	`372`	`fd=lfd.open(write=True,stream=True)`
`373`		`-ok=True`
	`373`	`+ok=False`
`374`	`374`	`try:`
`375`	`375`	`fd.write(write_value.encode("utf-8")+b"\n")`
`376`	`376`	`lfd.commit()`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit592ec84

File tree

1 file changed

1 file changed

`‎git/refs/symbolic.py`

0 commit comments