Commit56cc93a

sugi

authored and

derenio

committed

Fix fd leak on git cmd.

Currently if command is called with as_proces=True, pipes for thecommand will not be closed.This change makes sure to close command file descriptors.Conflicts:git/cmd.py

1 parent56d5d0c commit56cc93aCopy full SHA for 56cc93a

File tree

1 file changed

-0

lines changed

git
- cmd.py

1 file changed

-0

lines changed

`‎git/cmd.py‎`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -73,6 +73,9 @@ def __init__(self, proc, args ):`
`73`	`73`	`self.args=args`
`74`	`74`
`75`	`75`	`def__del__(self):`
	`76`	`+self.proc.stdout.close()`
	`77`	`+self.proc.stderr.close()`
	`78`	`+`
`76`	`79`	`# did the process finish already so we have a return code ?`
`77`	`80`	`ifself.proc.poll()isnotNone:`
`78`	`81`	`return`
`@@ -100,6 +103,8 @@ def wait(self):`
`100`	`103`
`101`	`104`	`:raise GitCommandError: if the return status is not 0"""`
`102`	`105`	`status=self.proc.wait()`
	`106`	`+self.proc.stdout.close()`
	`107`	`+self.proc.stderr.close()`
`103`	`108`	`ifstatus!=0:`
`104`	`109`	`raiseGitCommandError(self.args,status,self.proc.stderr.read())`
`105`	`110`	`# END status handling`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit56cc93a

File tree

1 file changed

1 file changed

`‎git/cmd.py‎`

0 commit comments