Commit4dfd480

committed

Fix how Remote annotates dynamic config-backed url attribute

This fixes a mypy error by replacing an annotation on `self.url`,which is a mypy error, by adding an annotation at the class levelfor a `url` instance attribute.This adds a corresponding brief docstring for it as well, which mayslightly improve usability, but the main impact is one less mypyerror.

1 parentc34a466 commit4dfd480Copy full SHA for 4dfd480

File tree

1 file changed

-1

lines changed

git
- remote.py

1 file changed

-1

lines changed

`‎git/remote.py`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -559,6 +559,9 @@ class Remote(LazyMixin, IterableObj):`
`559`	`559`	`"--exec",`
`560`	`560`	`]`
`561`	`561`
	`562`	`+url:str# Obtained dynamically from _config_reader. See __getattr__ below.`
	`563`	`+"""The URL configured for the remote."""`
	`564`	`+`
`562`	`565`	`def__init__(self,repo:"Repo",name:str)->None:`
`563`	`566`	`"""Initialize a remote instance.`
`564`	`567`
`@@ -570,7 +573,6 @@ def __init__(self, repo: "Repo", name: str) -> None:`
`570`	`573`	`"""`
`571`	`574`	`self.repo=repo`
`572`	`575`	`self.name=name`
`573`		`-self.url:str`
`574`	`576`
`575`	`577`	`def__getattr__(self,attr:str)->Any:`
`576`	`578`	"""Allows to call this instance like ``remote.special(args, *kwargs)`` to

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit4dfd480

File tree

1 file changed

1 file changed

`‎git/remote.py`

0 commit comments