Commit4b86993

committed

Use same code style for all logging without placeholders

When logging with only a msg argument, it is a full literal messagerather than a format string (as it is when there are placeholders).Thus both `...("%s", text)` and `...(text)`, where `...` is alogging method or function, are equally good code styles, provided`text` really is known to behave the same as `str(text)`.The latter style, `...(text)`, was used in all logging calls, bothin the git module and in the test suite, except one. This changesthe one outlier from `...("%s", text)` to `...(text)` for stylisticconsistency and to avoid giving the false impression that there issomething special about that call.

1 parent5faf621 commit4b86993Copy full SHA for 4b86993

File tree

1 file changed

-1

lines changed

test
- test_index.py

1 file changed

-1

lines changed

`‎test/test_index.py`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -174,7 +174,7 @@ def _decode(stdout):`
`174`	`174`	`exceptUnicodeDecodeError:`
`175`	`175`	`pass`
`176`	`176`	`exceptLookupErroraserror:`
`177`		`-_logger.warning("%s",str(error))# Message already says "Unknown encoding:".`
	`177`	`+_logger.warning(str(error))# Message already says "Unknown encoding:".`
`178`	`178`
`179`	`179`	`# Assume UTF-8. If invalid, substitute Unicode replacement characters.`
`180`	`180`	`returnstdout.decode("utf-8",errors="replace")`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit4b86993

File tree

1 file changed

1 file changed

`‎test/test_index.py`

0 commit comments