Commit46a739d

committed

Hoistimport git to module level in test module

Because it's going to be necessary to express things in terms of itin parametrization markings, in order for mypy to show the expectederrors for names that are available dynamically but deliberatelystatic type errors.

1 parent859e38c commit46a739dCopy full SHA for 46a739d

File tree

1 file changed

-11

lines changed

test/deprecation
- test_attributes.py

1 file changed

-11

lines changed

`‎test/deprecation/test_attributes.py`

Lines changed: 2 additions & 11 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,10 +4,10 @@`
`4`	`4`
`5`	`5`	`importpytest`
`6`	`6`
	`7`	`+importgit`
`7`	`8`
`8`		`-deftest_cannot_get_undefined()->None:`
`9`		`-importgit`
`10`	`9`
	`10`	`+deftest_cannot_get_undefined()->None:`
`11`	`11`	`withpytest.raises(AttributeError):`
`12`	`12`	`git.foo`
`13`	`13`
`@@ -19,21 +19,16 @@ def test_cannot_import_undefined() -> None:`
`19`	`19`
`20`	`20`	`deftest_util_alias_access_resolves()->None:`
`21`	`21`	`"""These resolve for now, though they're private we do not guarantee this."""`
`22`		`-importgit`
`23`		`-`
`24`	`22`	`assertgit.utilisgit.index.util`
`25`	`23`
`26`	`24`
`27`	`25`	`deftest_util_alias_import_resolves()->None:`
`28`	`26`	`fromgitimportutil`
`29`		`-importgit`
`30`	`27`
`31`	`28`	`utilisgit.index.util`
`32`	`29`
`33`	`30`
`34`	`31`	`deftest_util_alias_access_warns()->None:`
`35`		`-importgit`
`36`		`-`
`37`	`32`	`withpytest.deprecated_call()asctx:`
`38`	`33`	`git.util`
`39`	`34`
`@@ -72,8 +67,6 @@ def test_util_alias_import_warns() -> None:`
`72`	`67`	`@_parametrize_by_private_alias`
`73`	`68`	`deftest_private_module_alias_access_resolves(name:str,fullname:str)->None:`
`74`	`69`	`"""These resolve for now, though they're private we do not guarantee this."""`
`75`		`-importgit`
`76`		`-`
`77`	`70`	`assertgetattr(git,name)isimportlib.import_module(fullname)`
`78`	`71`
`79`	`72`
`@@ -85,8 +78,6 @@ def test_private_module_alias_import_resolves(name: str, fullname: str) -> None:`
`85`	`78`
`86`	`79`	`@_parametrize_by_private_alias`
`87`	`80`	`deftest_private_module_alias_access_warns(name:str,fullname:str)->None:`
`88`		`-importgit`
`89`		`-`
`90`	`81`	`withpytest.deprecated_call()asctx:`
`91`	`82`	`getattr(git,name)`
`92`	`83`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit46a739d

File tree

1 file changed

1 file changed

`‎test/deprecation/test_attributes.py`

0 commit comments