Commit454feda

James E. Blair

committed

Only gc.collect() under windows

Under Windows, tempfile objects are holding references to open filesuntil the garbage collector closes them and frees them. Explicitcalls to gc.collect() were added to the finalizer for the Repo classto force them to be closed synchronously. However, this is expensive,especially in large, long-running programs. As a temporary measureto alleviate the performance regression on other platforms, onlyperform these calls when running under Windows.Fixes#553

1 parentf237620 commit454fedaCopy full SHA for 454feda

File tree

1 file changed

+10

-2

lines changed

git/repo
- base.py

1 file changed

+10

-2

lines changed

`‎git/repo/base.py`

Lines changed: 10 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -209,9 +209,17 @@ def __del__(self):`
`209`	`209`	`defclose(self):`
`210`	`210`	`ifself.git:`
`211`	`211`	`self.git.clear_cache()`
`212`		`-gc.collect()`
	`212`	`+# Tempfiles objects on Windows are holding references to`
	`213`	`+# open files until they are collected by the garbage`
	`214`	`+# collector, thus preventing deletion.`
	`215`	`+# TODO: Find these references and ensure they are closed`
	`216`	`+# and deleted synchronously rather than forcing a gc`
	`217`	`+# collection.`
	`218`	`+ifis_win:`
	`219`	`+gc.collect()`
`213`	`220`	`gitdb.util.mman.collect()`
`214`		`-gc.collect()`
	`221`	`+ifis_win:`
	`222`	`+gc.collect()`
`215`	`223`
`216`	`224`	`def__eq__(self,rhs):`
`217`	`225`	`ifisinstance(rhs,Repo):`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit454feda

File tree

1 file changed

1 file changed

`‎git/repo/base.py`

0 commit comments