Commit43b7f8a

committed

Annotate safer_popen broad enough for all platforms

This fixes another static typing error reported by mypy.(The annotation could be made more specific in the future by makinga custom protocol for it, which may or may not be worthwhile, giventhat `**kwargs: Any` would still have to be present after whatevertyped keyword arguments the protocol's `__call__` method listed,since some callers intentionally forward arbitrary extra keywordarguments through safer_popen to Popen.)

1 parent3c5ca52 commit43b7f8aCopy full SHA for 43b7f8a

File tree

1 file changed

-0

lines changed

git
- cmd.py

1 file changed

-0

lines changed

`‎git/cmd.py`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -278,6 +278,8 @@ def _safer_popen_windows(`
`278`	`278`	`)`
`279`	`279`
`280`	`280`
	`281`	`+safer_popen:Callable[...,Popen]`
	`282`	`+`
`281`	`283`	`ifos.name=="nt":`
`282`	`284`	`safer_popen=_safer_popen_windows`
`283`	`285`	`else:`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit43b7f8a

File tree

1 file changed

1 file changed

`‎git/cmd.py`

0 commit comments