Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit3face90

Browse files
MarcelBeiningByron
authored andcommitted
allow calling index.add, index.move and index.remove with single items
added testing for itcloses#813
1 parent23b83cd commit3face90

File tree

2 files changed

+37
-18
lines changed

2 files changed

+37
-18
lines changed

‎git/index/base.py‎

Lines changed: 29 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -569,16 +569,23 @@ def _preprocess_add_items(self, items):
569569
""" Split the items into two lists of path strings and BaseEntries. """
570570
paths= []
571571
entries= []
572-
573-
foriteminitems:
574-
ifisinstance(item,string_types):
575-
paths.append(self._to_relative_path(item))
576-
elifisinstance(item, (Blob,Submodule)):
577-
entries.append(BaseIndexEntry.from_blob(item))
578-
elifisinstance(item,BaseIndexEntry):
579-
entries.append(item)
580-
else:
581-
raiseTypeError("Invalid Type: %r"%item)
572+
573+
ifisinstance(items,string_types):
574+
paths.append(self._to_relative_path(items))
575+
elifisinstance(items, (Blob,Submodule)):
576+
entries.append(BaseIndexEntry.from_blob(items))
577+
elifisinstance(items,BaseIndexEntry):
578+
entries.append(items)
579+
else:
580+
foriteminitems:
581+
ifisinstance(item,string_types):
582+
paths.append(self._to_relative_path(item))
583+
elifisinstance(item, (Blob,Submodule)):
584+
entries.append(BaseIndexEntry.from_blob(item))
585+
elifisinstance(item,BaseIndexEntry):
586+
entries.append(item)
587+
else:
588+
raiseTypeError("Invalid Type: %r"%item)
582589
# END for each item
583590
return (paths,entries)
584591

@@ -801,13 +808,18 @@ def _items_to_rela_paths(self, items):
801808
"""Returns a list of repo-relative paths from the given items which
802809
may be absolute or relative paths, entries or blobs"""
803810
paths= []
804-
foriteminitems:
805-
ifisinstance(item, (BaseIndexEntry, (Blob,Submodule))):
806-
paths.append(self._to_relative_path(item.path))
807-
elifisinstance(item,string_types):
808-
paths.append(self._to_relative_path(item))
809-
else:
810-
raiseTypeError("Invalid item type: %r"%item)
811+
ifisinstance(items, (BaseIndexEntry, (Blob,Submodule))):
812+
paths.append(self._to_relative_path(items.path))
813+
elifisinstance(items,string_types):
814+
paths.append(self._to_relative_path(items))
815+
else:
816+
foriteminitems:
817+
ifisinstance(item, (BaseIndexEntry, (Blob,Submodule))):
818+
paths.append(self._to_relative_path(item.path))
819+
elifisinstance(item,string_types):
820+
paths.append(self._to_relative_path(item))
821+
else:
822+
raiseTypeError("Invalid item type: %r"%item)
811823
# END for each item
812824
returnpaths
813825

‎git/test/test_index.py‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -772,7 +772,14 @@ def test_compare_write_tree(self, rw_repo):
772772
orig_tree=commit.tree
773773
self.assertEqual(index.write_tree(),orig_tree)
774774
# END for each commit
775-
775+
776+
@with_rw_repo('HEAD',bare=False)
777+
deftest_index_single_addremove(self,rw_repo):
778+
path=osp.join('git','test','test_index.py')
779+
self._assert_entries(rw_repo.index.add(path))
780+
deleted_files=rw_repo.index.remove(path)
781+
assertdeleted_files
782+
776783
deftest_index_new(self):
777784
B=self.rorepo.tree("6d9b1f4f9fa8c9f030e3207e7deacc5d5f8bba4e")
778785
H=self.rorepo.tree("25dca42bac17d511b7e2ebdd9d1d679e7626db5f")

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2026 Movatter.jp