Commit3a4fc6a

committed

Replace password in URI by stars if present + test

1 parent20f4a9d commit3a4fc6aCopy full SHA for 3a4fc6a

File tree

+18

-1

lines changed

+18

-1

lines changed

Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -969,7 +969,13 @@ def _clone(cls, git, url, path, odb_default_type, progress, multi_options=None,`
`969`	`969`	`handle_process_output(proc,None,progress.new_message_handler(),finalize_process,decode_streams=False)`
`970`	`970`	`else:`
`971`	`971`	`(stdout,stderr)=proc.communicate()`
`972`		`-log.debug("Cmd(%s)'s unused stdout: %s",getattr(proc,'args',''),stdout)`
	`972`	`+cmdline=getattr(proc,'args','')`
	`973`	`+uri=cmdline[-2]`
	`974`	`+if"://"inuriand"@"inuri:`
	`975`	`+cred=uri.split("://")[1].split("@")[0].split(":")`
	`976`	`+iflen(cred)==2:`
	`977`	`+cmdline[-2]=uri.replace(cred[1],"******")`
	`978`	`+log.debug("Cmd(%s)'s unused stdout: %s",cmdline,stdout)`
`973`	`979`	`finalize_process(proc,stderr=stderr)`
`974`	`980`
`975`	`981`	`# our git command could have a different working dir than our actual`

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -238,6 +238,17 @@ def test_clone_from_with_path_contains_unicode(self):`
`238`	`238`	`exceptUnicodeEncodeError:`
`239`	`239`	`self.fail('Raised UnicodeEncodeError')`
`240`	`240`
	`241`	`+@with_rw_directory`
	`242`	`+deftest_leaking_password_in_clone_logs(self,rw_dir):`
	`243`	`+"""Check that the password is not printed on the logs"""`
	`244`	`+password="fakepassword1234"`
	`245`	`+try:`
	`246`	`+Repo.clone_from(`
	`247`	`+url=f"https://fakeuser:{password}@fakerepo.example.com/testrepo",`
	`248`	`+to_path=rw_dir)`
	`249`	`+exceptGitCommandErroraserr:`
	`250`	`+assertpasswordnotinstr(err)`
	`251`	`+`
`241`	`252`	`@with_rw_repo('HEAD')`
`242`	`253`	`deftest_max_chunk_size(self,repo):`
`243`	`254`	`classTestOutputStream(TestBase):`

Comments

(0)