Commit38f5157

committed

add type check to conf_encoding (in thoery could be bool or int)

1 parent9d844a6 commit38f5157Copy full SHA for 38f5157

File tree

-959

lines changed

-959

lines changed

Lines changed: 3 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -109,18 +109,16 @@ def pump_stream(cmdline: List[str], name: str, stream: Union[BinaryIO, TextIO],`
`109`	`109`	`else:`
`110`	`110`	`handler(line)`
`111`	`111`	`exceptExceptionasex:`
`112`		`-log.error(f"Pumping{name!r} of cmd({remove_password_if_present(cmdline)})}faileddueto:{ex!r}")`
	`112`	`+log.error(f"Pumping{name!r} of cmd({remove_password_if_present(cmdline)}) failed due to:{ex!r}")`
`113`	`113`	`raiseCommandError([f'<{name}-pump>']+remove_password_if_present(cmdline),ex)fromex`
`114`	`114`	`finally:`
`115`	`115`	`stream.close()`
`116`	`116`
`117`		`-`
`118`		`-`
`119`	`117`	`ifhasattr(process,'proc'):`
`120`	`118`	`process=cast('Git.AutoInterrupt',process)`
`121`	`119`	`cmdline:str\|Tuple[str, ...]\|List[str]=getattr(process.proc,'args','')`
`122`		`-p_stdout=process.proc.stdout`
`123`		`-p_stderr=process.proc.stderr`
	`120`	`+p_stdout=process.proc.stdoutifprocess.procelseNone`
	`121`	`+p_stderr=process.proc.stderrifprocess.procelseNone`
`124`	`122`	`else:`
`125`	`123`	`process=cast(Popen,process)`
`126`	`124`	`cmdline=getattr(process,'args','')`

Lines changed: 1 addition & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@`
`31`	`31`	`# typing-------------------------------------------------------`
`32`	`32`
`33`	`33`	`fromtypingimport (Any,Callable,Generic,IO,List,Dict,Sequence,`
`34`		`-TYPE_CHECKING,Tuple,TypeVar,Union,cast,overload)`
	`34`	`+TYPE_CHECKING,Tuple,TypeVar,Union,cast)`
`35`	`35`
`36`	`36`	`fromgit.typesimportLit_config_levels,ConfigLevels_Tup,PathLike,assert_never,_T`
`37`	`37`
`@@ -709,15 +709,6 @@ def read_only(self) -> bool:`
`709`	`709`	`""":return: True if this instance may change the configuration file"""`
`710`	`710`	`returnself._read_only`
`711`	`711`
`712`		`-@overload`
`713`		`-defget_value(self,section:str,option:str,default:None=None)->Union[int,float,str,bool]: ...`
`714`		`-`
`715`		`-@overload`
`716`		`-defget_value(self,section:str,option:str,default:str)->str: ...`
`717`		`-`
`718`		`-@overload`
`719`		`-defget_value(self,section:str,option:str,default:float)->float: ...`
`720`		`-`
`721`	`712`	`defget_value(self,section:str,option:str,default:Union[int,float,str,bool,None]=None`
`722`	`713`	`)->Union[int,float,str,bool]:`
`723`	`714`	`# can default or return type include bool?`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -446,6 +446,8 @@ def create_from_tree(cls, repo: 'Repo', tree: Union[Tree, str], message: str,`
`446`	`446`	`# assume utf8 encoding`
`447`	`447`	`enc_section,enc_option=cls.conf_encoding.split('.')`
`448`	`448`	`conf_encoding=cr.get_value(enc_section,enc_option,cls.default_encoding)`
	`449`	`+ifnotisinstance(conf_encoding,str):`
	`450`	`+raiseTypeError("conf_encoding could not be coerced to str")`
`449`	`451`
`450`	`452`	`# if the tree is no object, make sure we create one - otherwise`
`451`	`453`	`# the created commit object is invalid`

Comments

(0)