Commit3250313

committed

Test that extra prefix "WARNING:" is omitted

This changes test_initial_refresh_from_bad_git_path_env_warn toassert a message with no added "WARNING:" prefix. As discussedin#1815, the extra prefix is confusing with logging configured,showing "CRITICAL:git.cmd:WARNING: Bad git executable." instead of"CRITICAL:git.cmd: Bad git executable."

1 parentdb36174 commit3250313Copy full SHA for 3250313

File tree

1 file changed

-1

lines changed

test
- test_git.py

1 file changed

-1

lines changed

`‎test/test_git.py`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -363,7 +363,7 @@ def test_initial_refresh_from_bad_git_path_env_warn(self, case):`
`363`	`363`	`refresh()`
`364`	`364`	`self.assertEqual(len(ctx.records),1)`
`365`	`365`	`message=ctx.records[0].getMessage()`
`366`		`-self.assertRegex(message,r"\AWARNING: Bad git executable.\n")`
	`366`	`+self.assertRegex(message,r"\ABad git executable.\n")`
`367`	`367`	`self.assertEqual(self.git.GIT_PYTHON_GIT_EXECUTABLE,"git")`
`368`	`368`
`369`	`369`	`@ddt.data(("2",), ("r",), ("raise",), ("e",), ("error",))`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit3250313

File tree

1 file changed

1 file changed

`‎test/test_git.py`

0 commit comments