Commit2ff3a3e

committed

fix(blame): lazily fetch full commit message

That way, we will not only get the summary linecontained in the blame, but fetch the full message.This is more costly than the previous implementationallowed it to be, but being less surprising/correctcertainly is the preferred behaviour here.Fixes#485

1 parent0ed3cd7 commit2ff3a3eCopy full SHA for 2ff3a3e

File tree

2 files changed

-5

lines changed

git
- repo
  - base.py
- test
  - test_repo.py

2 files changed

-5

lines changed

`‎git/repo/base.py`

Lines changed: 2 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -714,8 +714,7 @@ def blame_incremental(self, rev, file, **kwargs):`
`714`	`714`	`authored_date=int(props[b'author-time']),`
`715`	`715`	`committer=Actor(safe_decode(props[b'committer']),`
`716`	`716`	`safe_decode(props[b'committer-mail'].lstrip(b'<').rstrip(b'>'))),`
`717`		`-committed_date=int(props[b'committer-time']),`
`718`		`-message=safe_decode(props[b'summary']))`
	`717`	`+committed_date=int(props[b'committer-time']))`
`719`	`718`	`commits[hexsha]=c`
`720`	`719`	`else:`
`721`	`720`	`# Discard the next line (it's a filename end tag)`
`@@ -815,8 +814,7 @@ def blame(self, rev, file, incremental=False, **kwargs):`
`815`	`814`	`authored_date=info['author_date'],`
`816`	`815`	`committer=Actor._from_string(`
`817`	`816`	`info['committer']+' '+info['committer_email']),`
`818`		`-committed_date=info['committer_date'],`
`819`		`-message=info['summary'])`
	`817`	`+committed_date=info['committer_date'])`
`820`	`818`	`commits[sha]=c`
`821`	`819`	`# END if commit objects needs initial creation`
`822`	`820`	`ifnotis_binary:`

`‎git/test/test_repo.py`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -307,7 +307,7 @@ def test_should_display_blame_information(self, git):`
`307`	`307`	`assert_equal('Tom Preston-Werner',c.committer.name)`
`308`	`308`	`assert_equal('tom@mojombo.com',c.committer.email)`
`309`	`309`	`assert_equal(1191997100,c.committed_date)`
`310`		`-assert_equal('initial grit setup',c.message)`
	`310`	`+self.assertRaisesRegexp(ValueError,"634396b2f541a9f2d58b00be1a07f0c358b999b3 missing",lambda:c.message)`
`311`	`311`
`312`	`312`	`# test the 'lines per commit' entries`
`313`	`313`	`tlist=b[0][1]`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit2ff3a3e

File tree

2 files changed

2 files changed

`‎git/repo/base.py`

`‎git/test/test_repo.py`

0 commit comments