Commit2eac36c

committed

Have _fake_git fixture take version_info

This reorganization is to facilitate using two separate fake gitcommands with different versions, in forthcoming tests.

1 parent3f107d5 commit2eac36cCopy full SHA for 2eac36c

File tree

1 file changed

-8

lines changed

test
- test_git.py

1 file changed

-8

lines changed

`‎test/test_git.py`

Lines changed: 7 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -28,8 +28,6 @@`
`28`	`28`	`fromgit.utilimportcwd,finalize_process`
`29`	`29`	`fromtest.libimportTestBase,fixture_path,with_rw_directory`
`30`	`30`
`31`		`-_FAKE_GIT_VERSION_INFO= (123,456,789)`
`32`		`-`
`33`	`31`
`34`	`32`	`@contextlib.contextmanager`
`35`	`33`	`def_patch_out_env(name):`
`@@ -70,8 +68,8 @@ def _rollback_refresh():`
`70`	`68`
`71`	`69`
`72`	`70`	`@contextlib.contextmanager`
`73`		`-def_fake_git():`
`74`		`-fake_version=".".join(str(field)forfieldin_FAKE_GIT_VERSION_INFO)`
	`71`	`+def_fake_git(*version_info):`
	`72`	`+fake_version=".".join(map(str,version_info))`
`75`	`73`	`fake_output=f"git version{fake_version} (fake)"`
`76`	`74`
`77`	`75`	`withtempfile.TemporaryDirectory()astdir:`
`@@ -505,17 +503,18 @@ def test_refresh_with_good_relative_git_path_arg(self):`
`505`	`503`	`self.assertEqual(self.git.GIT_PYTHON_GIT_EXECUTABLE,absolute_path)`
`506`	`504`
`507`	`505`	`deftest_version_info_is_cached(self):`
	`506`	`+fake_version_info= (123,456,789)`
`508`	`507`	`with_rollback_refresh():`
`509`		`-with_fake_git()aspath:`
	`508`	`+with_fake_git(*fake_version_info)aspath:`
`510`	`509`	`new_git=Git()# Not cached yet.`
`511`	`510`	`refresh(path)`
`512`		`-self.assertEqual(new_git.version_info,_FAKE_GIT_VERSION_INFO)`
	`511`	`+self.assertEqual(new_git.version_info,fake_version_info)`
`513`	`512`	`os.remove(path)# Arrange that a second subprocess call would fail.`
`514`		`-self.assertEqual(new_git.version_info,_FAKE_GIT_VERSION_INFO)`
	`513`	`+self.assertEqual(new_git.version_info,fake_version_info)`
`515`	`514`
`516`	`515`	`deftest_version_info_cache_is_per_instance(self):`
`517`	`516`	`with_rollback_refresh():`
`518`		`-with_fake_git()aspath:`
	`517`	`+with_fake_git(123,456,789)aspath:`
`519`	`518`	`git1=Git()`
`520`	`519`	`git2=Git()`
`521`	`520`	`refresh(path)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit2eac36c

File tree

1 file changed

1 file changed

`‎test/test_git.py`

0 commit comments