Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork939
Commit2c7fce0
committed
Remove obsolete note in _iter_packed_refs
This removes a comment noting that a try-finally block had beenpresent (or had been intended), but was removed because someversion of Python had imposed a limitation on yield appearing intry-finally.That comment was obsolete as of58c5b99 (#326), which wrapped therelevant code in a with-statement, because:1. Since then, the cleanup is done in a manner equivaent to try-finally.2. It turned out, as noted in that PR, that cleanup had not always been done automatically. (This was contrary to the prediction given in the comment.)3. At some point before that, the limitation that had prevented the use of try-finally no longer affected any supported version of Python. Specifically, it appears the only limitation that this could be was the limitation lifted in Python 2.5, where along with the introduction of close(), which is automatically called when a generator object is finalized, it became permitted for yield to appear in a try-block with an associated finally-block, on the grounds that calling close() runs the finally-block (by raising GeneratorExit). For details, see:https://docs.python.org/3/whatsnew/2.5.html#pep-342-new-generator-features(This obsolete comment was one of the things I discovered whileworking on#1725, but I didn't include this change there, havingnot yet looked into the history of the code enough to be sure.)1 parent1755b1d commit2c7fce0
1 file changed
+0
-4
lines changedLines changed: 0 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
149 | 149 | | |
150 | 150 | | |
151 | 151 | | |
152 | | - | |
153 | | - | |
154 | | - | |
155 | | - | |
156 | 152 | | |
157 | 153 | | |
158 | 154 | | |
| |||
0 commit comments
Comments
(0)