Commit254305c

authored

Merge pull request#1299 from Lakhtenkov-iv/feature/clone-options-support-spaces

Added support of spaces for clone multi_options

2 parentsc5e6ae2 +717bfe9 commit254305cCopy full SHA for 254305c

File tree

-2

lines changed

-2

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,7 @@`
`6`	`6`	`importlogging`
`7`	`7`	`importos`
`8`	`8`	`importre`
	`9`	`+importshlex`
`9`	`10`	`importwarnings`
`10`	`11`	`fromgitdb.db.looseimportLooseObjectDB`
`11`	`12`
`@@ -1043,7 +1044,7 @@ def _clone(cls, git: 'Git', url: PathLike, path: PathLike, odb_default_type: Typ`
`1043`	`1044`	`kwargs['separate_git_dir']=Git.polish_url(sep_dir)`
`1044`	`1045`	`multi=None`
`1045`	`1046`	`ifmulti_options:`
`1046`		`-multi=' '.join(multi_options).split(' ')`
	`1047`	`+multi=shlex.split(' '.join(multi_options))`
`1047`	`1048`	`proc=git.clone(multi,Git.polish_url(str(url)),clone_path,with_extended_output=True,as_process=True,`
`1048`	`1049`	`v=True,universal_newlines=True,**add_progress(kwargs,git,progress))`
`1049`	`1050`	`ifprogress:`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -218,11 +218,13 @@ def test_clone_from_pathlib_withConfig(self, rw_dir):`
`218`	`218`	`cloned=Repo.clone_from(original_repo.git_dir,pathlib.Path(rw_dir)/"clone_pathlib_withConfig",`
`219`	`219`	`multi_options=["--recurse-submodules=repo",`
`220`	`220`	`"--config core.filemode=false",`
`221`		`-"--config submodule.repo.update=checkout"])`
	`221`	`+"--config submodule.repo.update=checkout",`
	`222`	`+"--config filter.lfs.clean='git-lfs clean -- %f'"])`
`222`	`223`
`223`	`224`	`self.assertEqual(cloned.config_reader().get_value('submodule','active'),'repo')`
`224`	`225`	`self.assertEqual(cloned.config_reader().get_value('core','filemode'),False)`
`225`	`226`	`self.assertEqual(cloned.config_reader().get_value('submodule "repo"','update'),'checkout')`
	`227`	`+self.assertEqual(cloned.config_reader().get_value('filter "lfs"','clean'),'git-lfs clean -- %f')`
`226`	`228`
`227`	`229`	`deftest_clone_from_with_path_contains_unicode(self):`
`228`	`230`	`withtempfile.TemporaryDirectory()astmpdir:`

Comments

(0)