Commit21c5f87

committed

Don't preinstall dependencies in test_installation

This removes the step in test_installation that did the equivalentof "pip install -r requirements.txt", because installing GitPythonis sufficient to install all its required dependencies, and it ismore important to test that than to test requirements.txt directly.Removing this causes the test to fail if installing the projectdoesn't entail installation of the requirements necessary to importthe git module or to cause gitdb to be found in a sys.path search.

1 parentb9b6d8c commit21c5f87Copy full SHA for 21c5f87

File tree

1 file changed

-10

lines changed

test
- test_installation.py

1 file changed

-10

lines changed

`‎test/test_installation.py`

Lines changed: 0 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -23,16 +23,6 @@ def setUp_venv(self, rw_dir):`
`23`	`23`	`@with_rw_directory`
`24`	`24`	`deftest_installation(self,rw_dir):`
`25`	`25`	`self.setUp_venv(rw_dir)`
`26`		`-result=subprocess.run(`
`27`		`- [self.pip,"install","-r","requirements.txt"],`
`28`		`-stdout=subprocess.PIPE,`
`29`		`-cwd=self.sources,`
`30`		`- )`
`31`		`-self.assertEqual(`
`32`		`-0,`
`33`		`-result.returncode,`
`34`		`-msg=result.stderrorresult.stdoutor"Can't install requirements",`
`35`		`- )`
`36`	`26`	`result=subprocess.run(`
`37`	`27`	`[self.pip,"install","."],`
`38`	`28`	`stdout=subprocess.PIPE,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit21c5f87

File tree

1 file changed

1 file changed

`‎test/test_installation.py`

0 commit comments