Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork941
Commit21875b5
committed
Don't split and glob the interpreter name
In the release building script, this changes $1 to "$1", because$1 without quotes means to perform word splitting and globbing(pathname expansion) on the parameter (unless otherwise disabled bythe value of $IFS or "set -f", respectively) and use the result ofdoing so, which isn't the intent of the code.This function is only used from within the script, where it isnot given values that would be changed by these additionalexpansions. So this is mainly about communicating intent.(If in the future it is intended that multiple arguments be usable,then they should be passed as separate arguments to release_with,which should be modified by replacing "$1" with "$@". I have notused "$@" at this time because it is not intuitively obvious thatthe arguments should be to the interpreter, rather than to thebuild module, so I don't think this should be supported unless oruntil a need for it determines that.)1 parent7dd8add commit21875b5
1 file changed
+1
-1
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| |||
0 commit comments
Comments
(0)