Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit1fa1ce2

Browse files
MarcelBeiningByron
authored andcommitted
fixed code repetition
1 parent3face90 commit1fa1ce2

File tree

1 file changed

+29
-30
lines changed

1 file changed

+29
-30
lines changed

‎git/index/base.py‎

Lines changed: 29 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -569,25 +569,23 @@ def _preprocess_add_items(self, items):
569569
""" Split the items into two lists of path strings and BaseEntries. """
570570
paths= []
571571
entries= []
572-
573-
ifisinstance(items,string_types):
574-
paths.append(self._to_relative_path(items))
575-
elifisinstance(items, (Blob,Submodule)):
576-
entries.append(BaseIndexEntry.from_blob(items))
577-
elifisinstance(items,BaseIndexEntry):
578-
entries.append(items)
579-
else:
580-
foriteminitems:
581-
ifisinstance(item,string_types):
582-
paths.append(self._to_relative_path(item))
583-
elifisinstance(item, (Blob,Submodule)):
584-
entries.append(BaseIndexEntry.from_blob(item))
585-
elifisinstance(item,BaseIndexEntry):
586-
entries.append(item)
587-
else:
588-
raiseTypeError("Invalid Type: %r"%item)
572+
# check if is iterable, else put in list
573+
try:
574+
test_item=iter(items)
575+
exceptTypeError:
576+
items= [items]
577+
578+
foriteminitems:
579+
ifisinstance(item,string_types):
580+
paths.append(self._to_relative_path(item))
581+
elifisinstance(item, (Blob,Submodule)):
582+
entries.append(BaseIndexEntry.from_blob(item))
583+
elifisinstance(item,BaseIndexEntry):
584+
entries.append(item)
585+
else:
586+
raiseTypeError("Invalid Type: %r"%item)
589587
# END for each item
590-
return(paths,entries)
588+
returnpaths,entries
591589

592590
def_store_path(self,filepath,fprogress):
593591
"""Store file at filepath in the database and return the base index entry
@@ -808,18 +806,19 @@ def _items_to_rela_paths(self, items):
808806
"""Returns a list of repo-relative paths from the given items which
809807
may be absolute or relative paths, entries or blobs"""
810808
paths= []
811-
ifisinstance(items, (BaseIndexEntry, (Blob,Submodule))):
812-
paths.append(self._to_relative_path(items.path))
813-
elifisinstance(items,string_types):
814-
paths.append(self._to_relative_path(items))
815-
else:
816-
foriteminitems:
817-
ifisinstance(item, (BaseIndexEntry, (Blob,Submodule))):
818-
paths.append(self._to_relative_path(item.path))
819-
elifisinstance(item,string_types):
820-
paths.append(self._to_relative_path(item))
821-
else:
822-
raiseTypeError("Invalid item type: %r"%item)
809+
# check if is iterable, else put in list
810+
try:
811+
test_item=iter(items)
812+
exceptTypeError:
813+
items= [items]
814+
815+
foriteminitems:
816+
ifisinstance(item, (BaseIndexEntry, (Blob,Submodule))):
817+
paths.append(self._to_relative_path(item.path))
818+
elifisinstance(item,string_types):
819+
paths.append(self._to_relative_path(item))
820+
else:
821+
raiseTypeError("Invalid item type: %r"%item)
823822
# END for each item
824823
returnpaths
825824

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2026 Movatter.jp