Commit19acd4c

committed

Add FIXME for what to do next

1 parent983fda7 commit19acd4cCopy full SHA for 19acd4c

File tree

+11

-0

lines changed

+11

-0

lines changed

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -103,3 +103,14 @@ def test_private_module_alias_import_warns(self, name: str, fullname: str) -> No`
`103`	`103`	`exec(f"from git import{name}")`
`104`	`104`
`105`	`105`	`assertctx[0].message.args[0].endswith(f"Use{fullname} instead.")`
	`106`	`+`
	`107`	`+`
	`108`	`+reveal_type(git.util.git_working_dir)`
	`109`	`+`
	`110`	`+# FIXME: Add one or more test cases that access something like git.util.git_working_dir`
	`111`	`+# to verify that it is available, and also use assert_type on it to ensure mypy knows`
	`112`	`+# that accesses to expressions of the form git.util.XYZ resolve to git.index.util.XYZ.`
	`113`	`+#`
	`114`	`+# It may be necessary for GitPython, in git/__init__.py, to import util from git.index`
	`115`	`+# explicitly before (still) deleting the util global, in order for mypy to know what is`
	`116`	`+# going on. Also check pyright.`

Comments

(0)