Commit0f19fb0

committed

Fix tests so they don't try to run "g"

Both new shell-related tests were causing the code under test tosplit "git" into ["g", "i", "t"] and thus causing the code undertest to attempt to execute a "g" command. This passes the commandas a one-element list of strings rather than as a string, whichavoids this on all operating systems regardless of whether the codeunder test has a bug being tested for.This would not occur on Windows, which does not iterate commands oftype str character-by-character even when the command is runwithout a shell. But it did happen on other systems.Most of the time, the benefit of using a command that actually runs"git" rather than "g" is the avoidance of confusion in the errormessage. But this is also important because it is possible for theuser who runs the tests to have a "g" command, in which case itcould be very inconvenient, or even unsafe, to run "g". This shouldbe avoided even when the code under test has a bug that causes ashell to be used when it shouldn't or not used when it should, sohaving separate commands (list and str) per test case parameterswould not be a sufficient solution: it would only guard againstrunning "g" when a bug in the code under test were absent.

1 parentaa5e2f6 commit0f19fb0Copy full SHA for 0f19fb0

File tree

1 file changed

-2

lines changed

test
- test_git.py

1 file changed

-2

lines changed

`‎test/test_git.py`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ def test_it_uses_shell_or_not_as_specified(self, case, mock_popen):`
`95`	`95`	`withmock.patch.object(Git,"USE_SHELL",value_from_class):`
`96`	`96`	`withcontextlib.suppress(GitCommandError):`
`97`	`97`	`self.git.execute(`
`98`		`-"git",# No args, so it runs with or without a shell, on all OSes.`
	`98`	`+["git"],# No args, so it runs with or without a shell, on all OSes.`
`99`	`99`	`shell=value_in_call,`
`100`	`100`	`)`
`101`	`101`
`@@ -112,7 +112,7 @@ def test_it_logs_if_it_uses_a_shell(self, case, mock_popen):`
`112`	`112`	`withmock.patch.object(Git,"USE_SHELL",value_from_class):`
`113`	`113`	`withcontextlib.suppress(GitCommandError):`
`114`	`114`	`self.git.execute(`
`115`		`-"git",# No args, so it runs with or without a shell, on all OSes.`
	`115`	`+["git"],# No args, so it runs with or without a shell, on all OSes.`
`116`	`116`	`shell=value_in_call,`
`117`	`117`	`)`
`118`	`118`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit0f19fb0

File tree

1 file changed

1 file changed

`‎test/test_git.py`

0 commit comments